HTML API: Refactor wp_targeted_link_rel #5590
Draft
+103
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
force-pushed
the
html-api/refactor-wp-targeted-link-rel-fake-html
branch
2 times, most recently
from
1c67c99
to
e7a8457
Compare
See WordPress#5143 This patch refactors `wp_targeted_link_rel` to be more reliable and clear by using the HTML API to replace existing PCRE code. It provides backwards compatability for the `rel` filter by creating a quick HTML string representing the opening A tag for the matched element and providing the `href`, `rel`, and `target` attributes on that tag.
Assert equivalent markup in existing Core tests. The Tag Processor may rearrange the attribute updates in relation to what the old code did, but the semantic output should be same.
dmsnell
force-pushed
the
html-api/refactor-wp-targeted-link-rel-fake-html
branch
from
dc75d0e
to
ad96a5e
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-targeted-link-rel-fake-html
branch
from
ad96a5e
to
406023c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5143
assertEqualMarkuponWP_UnitTestCaseThis patch refactors
wp_targeted_link_relto be more reliable and clear by using the HTML API to replace existing PCRE code. It provides backwards compatability for therelfilter by creating a quick HTML string representing the opening A tag for the matched element and providing thehref,rel, andtargetattributes on that tag.