Poc/early cache return #5663
Draft
Poc/early cache return #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a POC for early caching for WP_Query.
We have 38 filters in
get_posts. Even though we have caching implemented, caching doesn't actively skip all the filters.In most cases, these filters are only used for static modification of queries, so handling caching early using only the filter signature would let us skip all the filters for cached content.
Know issues which prevent caching from being moved on top for all the queries ->
current dateorcurrent userbased changes to the query or any other form of dynamic changes that cannot be recorded by filter signature alone.I have also done a performance test for this PoC, keeping
cache_earlyactive by default for all the queries. Even though the code could return the cache early, there wasn't any performance benefit as themes had 0 to no modification done to the query. However, this option could benefit a site using query filters for static changes alone and then use caching.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.