45714 - Allow all valid email formats when editing accounts #5708
Conversation
kebbet
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| * | ||
| * @ticket 45714 | ||
| */ | ||
| public function test_edit_user_sanitize_password() { |
There was a problem hiding this comment.
| public function test_edit_user_sanitize_password() { | |
| public function test_edit_user_sanitizes_email_address() { |
| // Success cases. | ||
| foreach ( array( | ||
| 'eusp2@example.com' => 'eusp2@example.com', | ||
| 'eusp3%4@example.com' => 'eusp3%4@example.com', | ||
| 'eusp4@example.com!' => 'eusp4@example.com', | ||
| ' eusp6@example.com%aa ' => 'eusp6@example.comaa', | ||
| 'eu\'sp@example.com' => 'eu\'sp@example.com', | ||
| ) as $em_pre => $em_post ) { | ||
| $_POST['email'] = $em_pre; | ||
|
|
||
| $user_id = edit_user( $user->ID ); | ||
|
|
||
| $this->assertIsInt( $user_id ); | ||
|
|
||
| $user = get_user_by( 'ID', $user_id ); | ||
|
|
||
| $this->assertInstanceOf( 'WP_User', $user ); | ||
| $this->assertEquals( $em_post, $user->user_email ); | ||
| } | ||
|
|
||
| // Failure cases (resulting in an invalid email address). | ||
| foreach ( array( | ||
| '' => '', | ||
| 'eusp5' => 'eusp5', | ||
| ) as $em_pre => $em_post ) { | ||
| $_POST['email'] = $em_pre; | ||
| $user_id = edit_user( $user->ID ); | ||
|
|
||
| $this->assertInstanceOf( 'WP_Error', $user_id ); | ||
| $this->assertEquals( 'empty_email', $user_id->get_error_code() ); | ||
| } |
There was a problem hiding this comment.
I recommend using a data provider instead
Porting original patch to GitHub.
https://core.trac.wordpress.org/ticket/45714
assertInternalTypeis used in the provided test which is anunidentified method.