Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix var types of parameters in sanitize_option() and sanitize_option_{$option} filter #5848

Closed
wants to merge 2 commits into from

Conversation

crstauf
Copy link

@crstauf crstauf commented Jan 9, 2024

Fixes the documentation of the parameters used in sanitize_option_{$option} filter.

Reported by gerardreches via User Contributed Notes.

Trac ticket: https://core.trac.wordpress.org/ticket/60214


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jan 9, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27
Copy link
Member

@crstauf left one minor question for clarification. Thanks!

@crstauf crstauf changed the title Fix var types of parameters in sanitize_option_{$option} filter Fix var types of parameters in sanitize_option() and sanitize_option_{$option} filter Jan 10, 2024
@crstauf
Copy link
Author

crstauf commented Jan 10, 2024

left one minor question for clarification. Thanks!

@mukeshpanchal27 Done. Thanks.

@audrasjb
Copy link
Contributor

@audrasjb audrasjb closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants