-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twenty Twenty-One: Fix typography settings for the quote block #5986
base: trunk
Are you sure you want to change the base?
Conversation
} | ||
|
||
cite, | ||
footer { | ||
font-weight: normal; | ||
color: var(--global--color-primary); | ||
font-size: var(--global--font-size-xs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the cite font size to make it change relatively to the quote block font size.
@@ -57,8 +62,6 @@ blockquote { | |||
|
|||
&:before { | |||
content: "\201C"; | |||
font-size: var(--quote--font-size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this to make the quote symbol size be relative to the font size because it did not look good when the font size was either very small or very large.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-content/themes/twentytwentyone/assets/sass/05-blocks/quote/_editor.scss
Outdated
Show resolved
Hide resolved
…ote/_editor.scss Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@@ -2,6 +2,12 @@ blockquote { | |||
padding: 0; | |||
position: relative; | |||
margin: var(--global--spacing-vertical) 0 var(--global--spacing-vertical) var(--global--spacing-horizontal); | |||
letter-spacing: var(--heading--letter-spacing-h4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure why the letter spacing is used here in the blockquote element, but not on the block. I can't recall. Maybe it was only intended for the classic editor quote.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/55991
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.