Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wp_sanitize_redirect to alias of sanitize_url #6024

Conversation

kkmuffme
Copy link

@kkmuffme kkmuffme commented Feb 4, 2024

sanitize_url() description says:

Sanitizes a URL for database or redirect usage.

Therefore a separate function does not make sense, as it creates inconsistent behavior.

Trac ticket: https://core.trac.wordpress.org/ticket/56160

Copy link

github-actions bot commented Feb 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kkmuffme.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@kkmuffme kkmuffme force-pushed the wp-sanitize-redirect-alias-of-sanitize-url branch from 9153a96 to 0ca2290 Compare February 4, 2024 12:25
Copy link

github-actions bot commented Feb 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@kkmuffme kkmuffme force-pushed the wp-sanitize-redirect-alias-of-sanitize-url branch from 0ca2290 to 0f841f7 Compare March 25, 2024 13:51
@kkmuffme kkmuffme closed this Mar 30, 2024
@kkmuffme kkmuffme deleted the wp-sanitize-redirect-alias-of-sanitize-url branch March 30, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant