-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Only set the card button status on plugin install pages. #6098
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
In my testing, can reproduce and these changes resolve the bug 🐛 ✅
Left a minor nit comment about spacing since touching that line of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
Committed in r57615. |
Previously, the
setCardButtonStatus()
JS function was called when a card had the IDplugin-information-footer
. However, the card will only exist on plugin install pages. This caused a failure when updating plugins from the plugin row onplugins.php
due to an undefined card.This adds a guard to ensure that the current page is one of the plugin install pages, preventing the error and allowing plugin updates from the
plugins.php
rows to work as expected.Trac ticket: https://core.trac.wordpress.org/ticket/60521