Fix mismatched parameter names in child classes (Trac 51553 - task 1) #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
trac-51553/mismatched-parameter-names
branch
from
409b3e4
to
35bbe54
Compare
|
Rebased for merge conflicts due to 5b6a20a |
|
@desrosj I would have happily rebased ... |
|
Sorry! I was actively reviewing so figured I'd just update to use the same PR. Updating the ticket soon! |
jrfnl
force-pushed
the
trac-51553/mismatched-parameter-names
branch
from
34f9683
to
b400b9f
Compare
jrfnl
force-pushed
the
trac-51553/mismatched-parameter-names
branch
2 times, most recently
from
795f67a
to
f6f903f
Compare
jrfnl
force-pushed
the
trac-51553/mismatched-parameter-names
branch
from
f6f903f
to
90955ba
Compare
Related to 51553 - Task 1
jrfnl
force-pushed
the
trac-51553/mismatched-parameter-names
branch
from
90955ba
to
e0ffece
Compare
Related to 51553 - Task 1
Related to 51553 - Task 1
Related to 51553 - Task 1
… as param When the name used in the child method was significantly more descriptive, the parameter is renamed, but the old name is still used within the function itself. Related to 51553 - Task 1 + Task 2-2
The parent class used `$current_object_id`, while most child classes used `$id`. Again, a parameter name mismatch. As `$current_object_id` is **more** descriptive than the extremely generic `$id`, we decided to use the parent class name everywhere. Related to 51553 - Task 1 + Task 2-2
…s param When the name used in the child method was significantly more descriptive, the parameter is renamed, but the old name is still used within the function itself. Related to 51553 - Task 1 + Task 2-2
…ed keyword as param When the name used in the child method was significantly more descriptive, the parameter is renamed, but the old name is still used within the function itself. Related to 51553 - Task 1 + Task 2-2
Related to 51553 - Task 1
Related to 51553 - Task 1
Related to 51553 - Task 1
Related to 51553 - Task 1
…mismatches Related to 51553 - Task 1
…tches Related to 51553 - Task 1
Related to 51553 - Task 1
…ches Related to 51553 - Task 1
Related to 51553 - Task 1
Related to 51553 - Task 1
jrfnl
force-pushed
the
trac-51553/mismatched-parameter-names
branch
from
e0ffece
to
c829005
Compare
hellofromtonya
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
I did a thorough deep code review multiple times during pair programming sessions with @jrfnl. The PR is ready for commit 👍
|
Each atomic commit as been committed with the following changesets https://core.trac.wordpress.org/log/?revs=51728,51734-51735,51737,51739,51779-51790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all known instances of parameter name mismatches between methods in child classes vs the names used in the parent class.
Notes:
Ref: https://www.php.net/manual/en/language.oop5.variance.php
Trac ticket: https://core.trac.wordpress.org/ticket/51553
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.