Plugin Dependencies: Don't assume API response has a slug
property.
#6151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
WP_Plugin_Dependencies::get_dependency_api_data()
attempted to set an array key using theslug
property returned in a Plugins API response. However, the Plugins API response is filterable and may not contain aslug
property.Earlier in the method, a local
$slug
variable is used as a key for the same array.For safety and consistency, this replaces array key references to
$information->slug
with$slug
.Trac ticket: https://core.trac.wordpress.org/ticket/60540