Update upload.php #6215
Update upload.php #6215
Conversation
Optimize code to reduce unwanted memory allocation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
src/wp-admin/upload.php
Outdated
| $modes = array( 'grid', 'list' ); | ||
|
|
||
| if ( isset( $_GET['mode'] ) && in_array( $_GET['mode'], $modes, true ) ) { | ||
| $mode = $_GET['mode']; | ||
| update_user_option( get_current_user_id(), 'media_library_mode', $mode ); | ||
| } | ||
| } else { | ||
| $mode = get_user_option( 'media_library_mode' ) ?: 'grid'; |
There was a problem hiding this comment.
Since short ternaries are not allowed in the WP coding standards.
| $mode = get_user_option( 'media_library_mode' ) ?: 'grid'; | |
| $mode = get_user_option( 'media_library_mode' ); | |
| $mode = $mode ? $mode : 'grid'; |
Using short ternaries is not allowed, so reverting ternary changes
| } | ||
| } else { | ||
| $mode = get_user_option( 'media_library_mode' ) ?: 'grid'; | ||
| } |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| $modes = array( 'grid', 'list' ); | ||
|
|
||
| if ( isset( $_GET['mode'] ) && in_array( $_GET['mode'], $modes, true ) ) { | ||
| $mode = $_GET['mode']; | ||
| update_user_option( get_current_user_id(), 'media_library_mode', $mode ); | ||
| } | ||
| } else { | ||
| $mode = get_user_option( 'media_library_mode', get_current_user_id() ) ? get_user_option( 'media_library_mode', get_current_user_id() ) : 'grid'; |
There was a problem hiding this comment.
| $mode = get_user_option( 'media_library_mode', get_current_user_id() ) ? get_user_option( 'media_library_mode', get_current_user_id() ) : 'grid'; | |
| $mode = get_user_option( 'media_library_mode', get_current_user_id() ) ? get_user_option( 'media_library_mode', get_current_user_id() ) : 'grid'; |
|
Thanks for the PR! Merged in r57796. |
Optimize code to reduce unwanted memory allocation
Trac ticket: https://core.trac.wordpress.org/ticket/60683
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.