Script Modules: Apply the script_loader_src to the module src
#6243
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * @return string The script module src with a version if relevant. | ||
| */ | ||
| private function get_versioned_src( array $script_module ): string { | ||
| $args = array(); | ||
| private function get_src( string $id ): string { |
There was a problem hiding this comment.
I originally changed this to get_versioned_src( $script_module, $id ) but it didn't make much sense given the former can be inferred from the latter.
The areas that calls this function could probably be optimized not to fetch the $script_module array and just the IDs, but I chose against doing that in this PR for simplicity.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…are unique and may have the same name. Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
There was a problem hiding this comment.
This looks good to me but it's probably worth getting a second set of eyes on it from someone involved in the original work (@westonruter I think you were?)
This will need to be ported to the Gutenberg compat shims too.
|
Committed in https://core.trac.wordpress.org/changeset/57840 |
Trac ticket: https://core.trac.wordpress.org/ticket/60742
See WordPress/wporg-mu-plugins#587
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.