Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Hooks: Remove filter global reset from test teardown #6244

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Mar 11, 2024

#6225 included a test that involved setting the $wp_current_filter global, and then removing it during teardown.

It was pointed out to me in Slack by @TimothyBJacobs that this is unnecessary:

Filters should get automatically reset by the parent tearDown implementation.

It's not the filter function I'm mocking though but the filter hook name (i.e. via the $wp_current_filter global)

I believe that should get reset as well.

$globals = array( 'wp_actions', 'wp_filters', 'wp_current_filter' );

This PR removes the unnecessary reset accordingly.

Follow-up [57790].

Trac ticket: https://core.trac.wordpress.org/ticket/60671


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham self-assigned this Mar 11, 2024
@ockham ockham marked this pull request as ready for review March 11, 2024 10:14
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bernhard-reiter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ockham
Copy link
Contributor Author

ockham commented Mar 11, 2024

Committed to Core in https://core.trac.wordpress.org/changeset/57799.

@ockham ockham closed this Mar 11, 2024
@ockham ockham deleted the remove/wp-current-filter-reset-during-teardown branch March 11, 2024 12:54
@ockham
Copy link
Contributor Author

ockham commented Mar 11, 2024

Backported to the 6.5 branch in https://core.trac.wordpress.org/changeset/57803.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant