Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Test Tools: migrate to Docker Compose v2 #6349

Closed

Conversation

swissspidy
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/60901


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@swissspidy swissspidy requested a review from desrosj April 3, 2024 09:12
Copy link

github-actions bot commented Apr 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props swissspidy, thelovekesh.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This comment was marked as resolved.

@swissspidy
Copy link
Member Author

The current test failures all seem to be related to 502 Bad Gateway errors on WordPress.org.

.github/workflows/end-to-end-tests.yml Outdated Show resolved Hide resolved
.github/workflows/performance.yml Outdated Show resolved Hide resolved
.github/workflows/phpunit-tests-run.yml Outdated Show resolved Hide resolved
.github/workflows/test-coverage.yml Outdated Show resolved Hide resolved
Co-authored-by: Lovekesh Kumar <ops.lovekesh@gmail.com>
@swissspidy swissspidy changed the title GitHub Actions: migrate to Docker Compose v2 Build/Test Tools: migrate to Docker Compose v2 Apr 3, 2024
@swissspidy
Copy link
Member Author

Some of the PHPUnit test failures are because the workflow uses the phpunit-tests-run.yml file from trunk, which doesn't yet have this fix.

This will be resolved when committing this change to trunk.

Same with the performance tests failures, which check out the previous commit which of course still uses docker-compose.

@swissspidy
Copy link
Member Author

Committed in https://core.trac.wordpress.org/changeset/57918

There will likely be some follow-up commits though.

@swissspidy swissspidy closed this Apr 3, 2024
@swissspidy swissspidy deleted the fix/docker-compose-v1-to-v2 branch April 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants