Accessibility Improvements for Application Passwords #51580 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle styling and normalize between different parts of the ui.
Be less generic
|
It also looks like each We also need to update |
The id / name doesn't matter anyways -- the JS doesn't key off it at all, so it's trivial.
Consistency with prior UI, as well as using a visible label instead of placeholder-as-label.
This reverts commit aaf5b20.
Changes from prior implementation in 53fca9b
Long lengths of italicized text can be hard for users to read. Also switches to built-in form style pattern.
|
Fixed in 5e31ccf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP improvements mitigating feedback for Application Passwords.
Trac ticket: https://core.trac.wordpress.org/ticket/51580#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.