Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Interactivity API store JSON encoding #6520

Closed
wants to merge 12 commits into from

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    a99ec25 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    8a6d30f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Remove JSON_HEX_AMP

    sirreal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    312d6ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e30117 View commit details
    Browse the repository at this point in the history
  3. Add comments

    sirreal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    cf29aa6 View commit details
    Browse the repository at this point in the history
  4. Smaller config in test

    sirreal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    76c7a5e View commit details
    Browse the repository at this point in the history
  5. Fix heredoc end

    sirreal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f2b07eb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5c2d273 View commit details
    Browse the repository at this point in the history
  7. Add more details to comments

    sirreal committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b9cd850 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Remove redundant tear_down method.

    Co-authored-by: Weston Ruter <westonruter@google.com>
    sirreal and westonruter committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8a7e4e0 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    67bd236 View commit details
    Browse the repository at this point in the history
  2. Rearrange comment and set UTF-8 as the normative encoding.

    Previously, the flags were set as if UTF-8 were conditionally present,
    but in most cases the blog character set will be UTF-8 and so flipping
    the logic makes it clearer that this is a "happy path" and also remove
    some logic that isn't necessary most of the time.
    
    I've reworded and combined the comment explaining the flags to be more
    specific about whey they are needed, and removed some discussions
    about encodings that I thought muddied the important details.
    dmsnell committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7ecc709 View commit details
    Browse the repository at this point in the history