Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Nineteen: Update editor styles for Archives and Categories List blocks #6548

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sabernhardt
Copy link

When users select center alignment for Archives or Categories List blocks, this would make the editor style match the text alignment used on the front end.

Trac 61186


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented May 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch tested. The content is not properly centred.

Before:
Before Patch

After:
Screenshot 2024-05-14 at 3 53 32 PM

@sabernhardt
Copy link
Author

Thanks for testing. I did not have the editor wide enough to notice the difference clearly.

However, the block alignment is actually correct for these blocks but not for the title, Paragraph blocks, etc. The front end centers .entry-content according to the page, and blocks within there align to the (left) side. The iframe editor aligns (most) blocks to the center of the canvas. Fixing that would belong on a separate ticket to test many more blocks and situations (possibly repurposing 53872, though a new ticket could be more appropriate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants