Update add new post type labels #6585
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
requested review from
peterwilsoncc,
youknowriad,
afercia,
audrasjb and
joedolson
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
This LGTM. I saw that we have three similar labels for taxonomies too. I wonder if we should align these as well. |
There was a problem hiding this comment.
As mentioned in https://core.trac.wordpress.org/ticket/61219#comment:4 I have no strong opinions about removing 'new'. However, I would like to see more feedback on the Trac ticket before merging this change.
More importantly, if we go with removing 'new' I would like to see this change made consistently throughout the entire codebase. It's not just about post type labels There's way more to change.
After applying the changes from this PR, I still can find 52 occurrences of translatable strings that start with ( 'Add new. They should be all changed as well.
Impact on plugins that may still use 'Add new' for their custom post types / taxonomies should be well considered too.
I agree with @afercia that if this change is to be made it ought to be done throughout the code base: add new plugin, add new theme and even the very well hidden add new link. I think this and WordPress/gutenberg#53984 can be solved independently and if anything the upstream ticket is actually an issue in WordPress-Develop if the strings aren't making it through to the editor interface. |
|
Agreed about consistency and making this change everywhere. I've update lots of files and hopefully haven't missed anything. |
| */ | ||
| if ( current_user_can( 'create_users' ) && apply_filters( 'show_network_site_users_add_new_form', true ) ) : | ||
| ?> | ||
| <h2 id="add-new-user"><?php _e( 'Add New User' ); ?></h2> | ||
| <h2 id="add-new-user"><?php _e( 'Add User' ); ?></h2> |
There was a problem hiding this comment.
I don't think this can be changed since the above section is "Add Existing User".
Trac ticket: https://core.trac.wordpress.org/ticket/61219
If "new" is removed from the add_new_item string for core post types then button labels can be shortened, and title case (which is inconsistent with Gutenberg buttons) sidestepped.
"Add New Post" → "Add Post"
"Add New Page" → "Add Page"
"Add New User" → "Add User"
"Add New Theme" → "Add Theme"
And so on.
It's most problematic in the Site Editor where labels like "Add New Template Part" feel unnecessarily verbose.
Description is from the ticket.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.