Script Loader: Fix missing block style loaded with style_handle
#6628
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -572,6 +572,7 @@ | |||
| add_action( 'admin_enqueue_scripts', 'wp_common_block_scripts_and_styles' ); | |||
| add_action( 'enqueue_block_assets', 'wp_enqueue_registered_block_scripts_and_styles' ); | |||
| add_action( 'enqueue_block_assets', 'enqueue_block_styles_assets', 30 ); | |||
| add_action( 'wp_loaded', 'enqueue_block_styles_handle_assets' ); | |||
There was a problem hiding this comment.
Does this change will impact on performance?
There was a problem hiding this comment.
Are we talking about server (PHP) or frontend (resources loading) performances ?
There was a problem hiding this comment.
Currently, if a block style is register with a style_handle the CSS file is not included on the frontend. This PR fix that, so it's possible that it'll have an impact in terms of performance.
We could try and mitigate this by dynamically adding a path extra data to the dependency to let WordPress inline the style if it's below the threshold.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Fix missing block style loaded with
style_handle.It's possible to register a block style with a handle instead of an inline style. In that case and when
wp_should_load_separate_core_block_assets()istrue, the current code will rely on therender_blockfilter to detect if the block is used on the page and the block style need to be enqueued.This doesn't work as expected, since the function is called in
enqueue_block_assetsafter therender_blockfilter has run.This PR add a new function hooked to
wp_loadedto fix the issue.Trac ticket: https://core.trac.wordpress.org/ticket/55184
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.