Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Test Tool updates to the 4.8 branch #894

Closed
wants to merge 24 commits into from

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Jan 21, 2021

This updates the 4.8 branch to run on the latest LTS version of NodeJS (currently 14.x).

Update devDependencies

All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

browserslist updates

This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

Generated files

All generated JS/CSS files have been updated.

Simulating build server output

A companion PR has been opened to simulate the output of the build server after the changes in this PR: WordPress/WordPress#515.

Trac ticket: https://core.trac.wordpress.org/ticket/52341


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

This package was added in http://core.trac.wordpress.org/changeset/49532, but is not actually necessary.
This backports all of the needed changes to allow the 4.8 branch to run on the latest LTS version of NodeJS (currently 14.x).

This commit includes the following backports:
- https://core.trac.wordpress.org/changeset/42460 (full)
- https://core.trac.wordpress.org/changeset/42461 (full)
- https://core.trac.wordpress.org/changeset/42463 (full)
- https://core.trac.wordpress.org/changeset/42887 (full)
- https://core.trac.wordpress.org/changeset/43320 (full)
- https://core.trac.wordpress.org/changeset/43323 (partial)
- https://core.trac.wordpress.org/changeset/43977 (partial)
- https://core.trac.wordpress.org/changeset/44219 (partial)
- https://core.trac.wordpress.org/changeset/44233 (partial)
- https://core.trac.wordpress.org/changeset/44728 (partial)
- https://core.trac.wordpress.org/changeset/45321 (partial)
- https://core.trac.wordpress.org/changeset/45765 (full)
- https://core.trac.wordpress.org/changeset/46404 (partial)
- https://core.trac.wordpress.org/changeset/46408 (partial)
- https://core.trac.wordpress.org/changeset/46409 (partial)
- https://core.trac.wordpress.org/changeset/47404 (partial)
- https://core.trac.wordpress.org/changeset/47867 (partial)
- https://core.trac.wordpress.org/changeset/47868 (partial)
- https://core.trac.wordpress.org/changeset/47869 (partial)
- https://core.trac.wordpress.org/changeset/47872 (full)
- https://core.trac.wordpress.org/changeset/47873 (partial)
- https://core.trac.wordpress.org/changeset/48705 (partial)
- https://core.trac.wordpress.org/changeset/49636 (full)
- https://core.trac.wordpress.org/changeset/49933 (partial)
- https://core.trac.wordpress.org/changeset/49937 (partial)
- https://core.trac.wordpress.org/changeset/49939 (partial)
`grunt-browserify` was removed from Core in https://core.trac.wordpress.org/changeset/41752, but should be made up to date in the 4.8 branch.
`grunt-contrib-compress` was removed from Core in https://core.trac.wordpress.org/changeset/44651/, but should be made up to date in the 4.8 branch.
This updates the `npm-shrinkwrap.json` file using `npm shrinkwrap --no-optional' after applying all package updates.
This changes the `.nvmrc` file from `14.15.0` to `14`. This will ensure the latest release of NodeJS14 is used going forwards.

It also changes the `engines` versions to ranges using `>=`. These values are advisory only, but indicating a range will hopefully encourage folks to run the most recent version of NodeJS.
@desrosj desrosj self-assigned this Jan 21, 2021
@desrosj desrosj marked this pull request as ready for review January 21, 2021 23:59
desrosj and others added 15 commits January 22, 2021 11:00
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".

Merges [43511], [43512], [46682], [46996] to the 4.8 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.8@50087 602fd350-edb4-49c9-b593-d223f7449a82
This package was added in http://core.trac.wordpress.org/changeset/49532, but is not actually necessary.
This backports all of the needed changes to allow the 4.8 branch to run on the latest LTS version of NodeJS (currently 14.x).

This commit includes the following backports:
- https://core.trac.wordpress.org/changeset/42460 (full)
- https://core.trac.wordpress.org/changeset/42461 (full)
- https://core.trac.wordpress.org/changeset/42463 (full)
- https://core.trac.wordpress.org/changeset/42887 (full)
- https://core.trac.wordpress.org/changeset/43320 (full)
- https://core.trac.wordpress.org/changeset/43323 (partial)
- https://core.trac.wordpress.org/changeset/43977 (partial)
- https://core.trac.wordpress.org/changeset/44219 (partial)
- https://core.trac.wordpress.org/changeset/44233 (partial)
- https://core.trac.wordpress.org/changeset/44728 (partial)
- https://core.trac.wordpress.org/changeset/45321 (partial)
- https://core.trac.wordpress.org/changeset/45765 (full)
- https://core.trac.wordpress.org/changeset/46404 (partial)
- https://core.trac.wordpress.org/changeset/46408 (partial)
- https://core.trac.wordpress.org/changeset/46409 (partial)
- https://core.trac.wordpress.org/changeset/47404 (partial)
- https://core.trac.wordpress.org/changeset/47867 (partial)
- https://core.trac.wordpress.org/changeset/47868 (partial)
- https://core.trac.wordpress.org/changeset/47869 (partial)
- https://core.trac.wordpress.org/changeset/47872 (full)
- https://core.trac.wordpress.org/changeset/47873 (partial)
- https://core.trac.wordpress.org/changeset/48705 (partial)
- https://core.trac.wordpress.org/changeset/49636 (full)
- https://core.trac.wordpress.org/changeset/49933 (partial)
- https://core.trac.wordpress.org/changeset/49937 (partial)
- https://core.trac.wordpress.org/changeset/49939 (partial)
`grunt-browserify` was removed from Core in https://core.trac.wordpress.org/changeset/41752, but should be made up to date in the 4.8 branch.
`grunt-contrib-compress` was removed from Core in https://core.trac.wordpress.org/changeset/44651/, but should be made up to date in the 4.8 branch.
This updates the `npm-shrinkwrap.json` file using `npm shrinkwrap --no-optional' after applying all package updates.
This changes the `.nvmrc` file from `14.15.0` to `14`. This will ensure the latest release of NodeJS14 is used going forwards.

It also changes the `engines` versions to ranges using `>=`. These values are advisory only, but indicating a range will hopefully encourage folks to run the most recent version of NodeJS.
@desrosj
Copy link
Contributor Author

desrosj commented Feb 5, 2021

Merged into Core in https://core.trac.wordpress.org/changeset/50203.

@desrosj desrosj closed this Feb 5, 2021
@desrosj desrosj deleted the node-update/4.8 branch February 5, 2021 04:10
@desrosj desrosj restored the node-update/4.8 branch February 8, 2021 15:02
@desrosj desrosj deleted the node-update/4.8 branch February 8, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants