Skip to content

Commit

Permalink
Blueprints: Mark shorthand properties as stable, not deprecated (#1594)
Browse files Browse the repository at this point in the history
Now that Blueprint shorthand properties like `constants`, `siteOptions`,
and `plugins` are here to stay and featured in the official docs, it's
probably safe to remove the warnings from the schema (see these lines).

Closes #1282
  • Loading branch information
adamziel committed Jul 10, 2024
1 parent 70f590e commit cffa3e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
9 changes: 3 additions & 6 deletions packages/playground/blueprints/public/blueprint-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@
"additionalProperties": {
"type": "string"
},
"description": "PHP Constants to define on every request",
"deprecated": "This experimental option will change without warning.\nUse `steps` instead."
"description": "PHP Constants to define on every request"
},
"plugins": {
"type": "array",
Expand All @@ -95,8 +94,7 @@
}
]
},
"description": "WordPress plugins to install and activate",
"deprecated": "This experimental option will change without warning.\nUse `steps` instead."
"description": "WordPress plugins to install and activate"
},
"siteOptions": {
"type": "object",
Expand All @@ -109,8 +107,7 @@
"description": "The site title"
}
},
"description": "WordPress site options to define",
"deprecated": "This experimental option will change without warning.\nUse `steps` instead."
"description": "WordPress site options to define"
},
"login": {
"anyOf": [
Expand Down
6 changes: 0 additions & 6 deletions packages/playground/blueprints/src/lib/blueprint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,16 @@ export interface Blueprint {

/**
* PHP Constants to define on every request
* @deprecated This experimental option will change without warning.
* Use `steps` instead.
*/
constants?: Record<string, string>;

/**
* WordPress plugins to install and activate
* @deprecated This experimental option will change without warning.
* Use `steps` instead.
*/
plugins?: Array<string | FileReference>;

/**
* WordPress site options to define
* @deprecated This experimental option will change without warning.
* Use `steps` instead.
*/
siteOptions?: Record<string, string> & {
/** The site title */
Expand Down

0 comments on commit cffa3e2

Please sign in to comment.