-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devex: Console.log an explanation of CORS issues to clarify why, e.g., zips from GitHub urls cant be downloaded #1205
Comments
@helgatheviking you can load files using the https://raw.githubusercontent.com/ URL. The culprit are CORS header – the site must serve Also – I just wrote this guide on Blueprints. It might help you and I would be very interested in your feedback: |
Actually, let's reuse this issue to explain the downloading issue right in the error message in the console. |
Ah ok. I didn't know there would be a difference. That's not ideal, but doable to get this working. What about uploading a single file:
is that possible? |
It is! Check that crash course for details on how to do it, it won't be the installPlugin step |
Fixes #1205 ## What is this PR doing? It adds an error message for blueprint network errors. ## What problem is it solving? It will help users identify the root cause of blueprints failing. ## How is the problem addressed? By returning a custom error message with debug instructions. ## Testing Instructions - Checkout this branch - [Open Playground with this blueprint](http://localhost:5400/website-server/#{%20%22features%22:%20{%20%22networking%22:%20true%20},%20%22steps%22:%20[%20{%20%22step%22:%20%22installPlugin%22,%20%22pluginZipFile%22:%20{%20%22resource%22:%20%22url%22,%20%22url%22:%20%22https://github.com/helgatheviking/simple-user-listing-demo-avatars/releases/download/1.0.0/simple-user-listing-demo-avatars.1.0.0.zip%22%20},%20%22options%22:%20{%20%22activate%22:%20true%20}%20}%20]%20}) - Open the browser console and see the new error **Note**: The error is currently displayed multiple times because of uncaught promises somewhere in the code. --------- Co-authored-by: Adam Zielinski <adam@adamziel.com>
I have a little snippet I would like to install to make my plugin's playground preview look nicer. So I pushed it to github and created a zip release for it.
I've added a step to my blueprint.json that attempts to install the plugin from a URL resource:
But the playground fails even though I have networking turned on
here's the error I see in the console (which looks like a networking failure)
The text was updated successfully, but these errors were encountered: