Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runPHPWithOptions step in the example doesn't match with the heading #1374

Open
juanmaguitar opened this issue May 9, 2024 · 2 comments · Fixed by #1377
Open

runPHPWithOptions step in the example doesn't match with the heading #1374

juanmaguitar opened this issue May 9, 2024 · 2 comments · Fixed by #1377

Comments

@juanmaguitar
Copy link
Contributor

The step runPHPWithOptions example doesn't match the step stated in the heading.

The example of runPHPWithOptions is:

{
    "steps": [
        {
            "step": "runPHP",
            "options": {
              ...
            }
        }
    ]
}

Should it be instead?

{
    "steps": [
        {
            "step": "runPHPWithOptions",
            "options": {
              ...
            }
        }
    ]
}
adamziel added a commit that referenced this issue May 9, 2024
Changing the headings for each step at
https://wordpress.github.io/wordpress-playground/blueprints-api/steps to
correspond with the real value of the step property in the blueprint

The `ActivatePluginStep` heading becomes `activatePlugin`, `CpStep`
becomes `cp` and so on.

Closes #1375
Closes #1374

cc @juanmaguitar
adamziel added a commit that referenced this issue May 9, 2024
Changing the headings for each step at
https://wordpress.github.io/wordpress-playground/blueprints-api/steps to
correspond with the real value of the step property in the blueprint

The `ActivatePluginStep` heading becomes `activatePlugin`, `CpStep`
becomes `cp` and so on.

Closes #1375
Closes #1374

cc @juanmaguitar
@juanmaguitar
Copy link
Contributor Author

@adamziel I think the example at runPHPWithOptions still needs to be updated to reflect the right step name

 "step": "runPHPWithOptions",

@adamziel
Copy link
Collaborator

Aha, correct

@adamziel adamziel reopened this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants