PHP: mount() should not create a directory when mounting a file

[adamziel]

The mount() method calls mkdirTree() internally to ensure the target path exists – otherwise Emscripten throws an error. The problem is, sometimes we want to mount a file and not a directory. In these cases, the mount() method will still create that empty dir:

wordpress-playground/packages/php-wasm/node/src/lib/node-php.ts

Lines 129 to 132 in 413d07f

	mount(localPath: string | MountSettings, virtualFSPath: string) {
	if (!this.fileExists(virtualFSPath)) {
	this.mkdirTree(virtualFSPath);
	}

Let's:

• Add a check like !this.isDir(localPath)
• Add a unit test in php-spec.ts to prevent regressions

[danielbachhuber]

Will this help fix WordPress/playground-tools#32 ?

[adamziel]

@danielbachhuber I think so! Would be great to create a failing test in wp-now repo, fix it, and see what it does to the test