Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordpress.github.io/wordpress-playground - Footer styling issues #954

Closed
tommusrhodus opened this issue Jan 17, 2024 · 2 comments
Closed

wordpress.github.io/wordpress-playground - Footer styling issues #954

tommusrhodus opened this issue Jan 17, 2024 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation

Comments

@tommusrhodus
Copy link

  • Light mode only: Footer links on hover disappear into the background
  • Light and Dark mode: code is poetry footer link is extremely difficult to see.

Both screenshots from Mac OS 14.1.2, Google Chrome 120.0.6099.216

Screenshot 2024-01-17 at 16 33 03

Screenshot 2024-01-17 at 16 31 58
@marcarmengou marcarmengou mentioned this issue Jan 18, 2024
Merged
adamziel pushed a commit that referenced this issue Jan 18, 2024
@marcarmengou
Fix footer styling issues in wordpress.github.io/wordpress-playground (…
b44c140 
…#956)

Fix footer styling issues in wordpress.github.io/wordpress-playground in
#954
@marcarmengou marcarmengou mentioned this issue Jan 18, 2024
Merged
adamziel pushed a commit that referenced this issue Jan 29, 2024
@marcarmengou
Fix footer styling issue in the "Code is Poetry" in wordpress.github.…
bdd4ea2 
…io/wordpress-playground (#959)

It seems that the original opacity style prevails in the "Code is
poetry" image link after
#956 .

I will make a new PR to add "!important".

This should solve this issue:
#954
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation labels Jan 29, 2024
@adamziel
Copy link
Collaborator

The :hover state is now fixed in #956, the only remaining issue is the Code is Poetry contrast. While I agree it may be difficult to see, it seems like a deliberate design decision around WordPress.org redesign as it looks exactly like that on w.org:

CleanShot 2024-01-30 at 09 55 18@2x

Can you confirm @jasmussen?

I'm going to close this issue for now, but we can keep discussing and reopen if the conclusion is to increase that contrast.

@jasmussen
Copy link

Code is poetry is decorative, yes. By the way, there's https://github.com/WordPress/wporg-main-2022/issues for wp.org wide conversations too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamziel @jasmussen @tommusrhodus