Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Clean up after node PHP popen() test #1280

Merged

Conversation

brandonpayton
Copy link
Member

What is this PR doing?

This cleans up an untracked file that is created by the unit tests. Otherwise, there is an untracked "out" file leftover after running the tests.

Testing Instructions

CI

@brandonpayton brandonpayton self-assigned this Apr 19, 2024
Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that file was bothering me, but I was too lazy to fix it.

@adamziel adamziel merged commit 451b419 into WordPress:trunk Apr 19, 2024
5 checks passed
@brandonpayton brandonpayton deleted the clean-up-after-node-php-test branch April 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants