Blueprint Builder: Fix stuck loader bar #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the stuck Playground loading process on https://playground.wordpress.net/builder/builder.html Technically, we trash the existing iframe and start a new one instead of trying to bind multiple Playground clients to the same one. They very likely competed for events and missing even a single one meant not finishing the Playground loading sequence. This also fixes the following issues with the builder: * Cmd+s saving the Blueprint to the disk instead of running it * Too many double quotes inserted when completing a step name ## Follow-up work Scrap the entire Builder codebase and rebuild it with CodeMirror and generic autocompletion (Ace doesn't work well for mobile, and the current autocompletion is bound to an exact JSON schema shape). ## Testing plan 1. Go to http://127.0.0.1:5400/website-server/builder/builder.html 1. Run a few Blueprints 1. Reload them 40 times 1. Confirm Playground loaded every single time
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the stuck Playground loading process on
https://playground.wordpress.net/builder/builder.html
Technically, we trash the existing iframe and start a new one instead of trying to bind multiple Playground clients to the same one. They very likely competed for events and missing even a single one meant not finishing the Playground loading sequence.
This also fixes the following issues with the builder:
Furthermore, it adds an "Edit the Blueprint" link to the hamburger menu.
Closes #863
Follow-up work
Scrap the entire Builder codebase and rebuild it with CodeMirror and generic autocompletion (Ace doesn't work well for mobile, and the current autocompletion is bound to an exact JSON schema shape).
Testing plan