PHP: Remove setSapiName, setPhpIniEntry, setPhpIniPath methods from the remote PHP API client #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he remote PHP API client setSapiName, setPhpIniEntry, setPhpIniPath are methods that must either be called synchronously before the PHP internal state is initialized, or with a complex argument that can't be serialized over a remote connection. They can only be used in the same process before PHP is fully initialized and have never worked correctly when connecting a Playground API client to `remote.html`. Removing them makes that apparent, prevents confusing API interactions. In addition, it sets the stage for supporting a [Loopback Request](#1287) as the backend for the API endpoint switches from a single PHP instance to a PHPRequestHandler, and here we're removing an API surface that needs to impact all existing and future PHP instances. ## Testing instructions Confirm the CI checks pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSapiName,setPhpIniEntry, andsetPhpIniPathare methods that must either be called synchronously before the PHP internal state is initialized, or with a complex argument that can't be serialized over a remote connection.They can only be used in the same process before PHP is fully initialized and have never worked correctly when connecting a Playground API client to
remote.html.Removing them makes that apparent, prevents confusing API interactions.
In addition, it sets the stage for supporting
a Loopback
Request as the backend for the API endpoint switches from a single PHP instance to a PHPRequestHandler, and here we're removing an API surface that needs to impact all existing and future PHP instances.
Testing instructions
Confirm the CI checks pass.