Eliminate 404s due to nested files-to-serve-via-php dir #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Fixes website breakage due to a files-to-serve-via-php directory being nested within another files-to-serve-via-php-directory. When this occurs, files are more nested than expected and cannot be found.
What problem is it solving?
During deployment we list files within a directory structure and move them conditionally. Because this is done with a
findpiped to bash functions that move files tofiles-to-serve-via-phpwithin the same parent dir, it appears moved files are later discovered byfindcausing them to be moved again and creating a nested directory structure.How is the problem addressed?
By filtering out paths that include the string
files-to-serve-via-phpto prevent them from being moved again.Testing Instructions