Website: Update rsync command to clean up more completely #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Tightens the rsync command used to sync website files to WP Cloud so that removed files are properly removed.
Related to #1197
What problem is it solving?
To avoid an rsync error about not being able to set mtime or permissions of
/srv/htdocs, which is owned by root, we previously used a wildcard in the source likersync -av --delete source-dir/* target-dir/. A problem with this is that, when files are removed from the relative root, they are not considered for deletion because they do not belong to a subtree matched by the wildcard.How is the problem addressed?
The rsync command is fixed to no longer update file permissions and to skip updating times on directories. This should keep it from attempting to update
/srv/htdocsand erroring.Testing Instructions
Test manually on playground-dot-wordpress-dot-net.atomicsites.blog