PHP: Move internal shared directories to /internal/shared #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of internal directories and files shared between all the PHPProcessManager processes keeps growing so it makes sense to move them all under a common root. This PR introduces an `/internal/shared` directory that's a home to: * `php.ini` * `phpinfo.php` * `preload/` directory with custom PHP files * `ca-bundle.crt` for SSL connections * `consts.json` * `consts.php` * Soon also db.php and sqlite-database-integration ## Testing instructions Confirm all the tests passed
adamziel
added
[Type] Enhancement
adamziel
added a commit
that referenced
this pull request
May 14, 2024
…to_prepend_file.php file exists Filesystem files are shared between PHP instances within the same PHPProcessManager, but php.ini entry are kept in WASM memory and must be set on every PHP instance separately. Therefore, the `auto_prepend_file` must always be set in `#initWebRuntime` Fixes a regression introduced in #1386 To test, run `bun packages/playground/cli/src/cli.ts server --login` and confirm it finishes without any errors.
adamziel
added a commit
that referenced
this pull request
May 14, 2024
…to_prepend_file.php file exists (#1388) Filesystem files are shared between PHP instances within the same PHPProcessManager, but php.ini entry are kept in WASM memory and must be set on every PHP instance separately. Therefore, the `auto_prepend_file` must always be set in `#initWebRuntime` Fixes a regression introduced in #1386 To test, run `bun packages/playground/cli/src/cli.ts server --login` and confirm it finishes without any errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of internal directories and files shared between all the PHPProcessManager processes keeps growing so it makes sense to move them all under a common root. This PR introduces an
/internal/shareddirectory that's a home to:php.iniphpinfo.phppreload/directory with custom PHP filesca-bundle.crtfor SSL connectionsconsts.jsonconsts.phpTesting instructions
Confirm all the tests passed