PHP: Support php.mv() between devices via recursive copy #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
php.mv()from MEMFS to NODEFS would fail. With this PR, it works.Technically, this PR checks if
fromPathandtoPathbelong to the same mountpoint. If yes, it calls a fastFS.rename()function. If not, it runs a slower recursive copy followed by recursive remove of thefromPath.This runs the entire recursive copy and only then runs the recursive delete. I wonder if deleting each copied item as we go would make more sense?
This PR also brings in the Emscripten TS types as they made working with the
FSobject much easier.Testing Instructions
Review the new unit test and confirm it passes.