-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprints: Support zipped assets without top-level folder #491
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,8 +51,7 @@ foreach ( ( glob( $plugin_path . '/*.php' ) ?: array() ) as $file ) { | |
echo 'NO_ENTRY_FILE'; | ||
`, | ||
}); | ||
if (result.errors) throw new Error(result.errors); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some plugins trigger warnings during the installation and they show as |
||
if (result.text === 'NO_ENTRY_FILE') { | ||
if (result.text.endsWith('NO_ENTRY_FILE')) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some plugins trigger warnings during the installation – let's check just the last part of the output text |
||
throw new Error('Could not find plugin entry file.'); | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resource returned a full path as a file name and that threw off installAsset