Browser: Patch Gutenberg on site import #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
adamziel
added a commit
that referenced
this pull request
Jan 12, 2024
Adds e2e tests for #938 ## Testing Instructions Confirm the tests pass :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Related to #646
Applies the missing Playground patch for Gutenberg when importing a Playground site with an unpatched Gutenberg bundled.
Without this PR, importing such a site zip file results in this broken state:
Here’s a replication link: annezazu/playground#2
Testing instructions
Go to http://localhost:5400/website-server/?import-site=https%3A%2F%2Fraw.githubusercontent.com%2Fannezazu%2Fplayground%2Fplayground-changes-2023-12-20T17-29-06-815Z%2Fplayground%2Fplayground.zip&url=/wp-admin/post-new.php and confirm the inserter button is styled correctly.
It would be great to ship an E2E test as a follow-up PR. This one is important enough that I won't block it on lack of a test.
cc @annezazu