Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update event list UI: Reorder event information and display event type #152

Closed

Conversation

renintw
Copy link

@renintw renintw commented Jun 12, 2023

See WordPress/wordcamp.org#894

This PR aims to improve the event list user interface by rearranging the information for each event and displaying the event type prominently. The changes include:

This update is being made in order to support the The Next Generation of WordCamps pilot event program. More traffic will be directed to this page (community/events) and clearly communicating the event type has been identified as a needed improvement.

  • Moving the time information to the first line.
  • Keeping the event name in the second line.
  • Placing the location information in the third line.
  • Introducing the event type and putting it before the location for better identification.

Screenshots

Before After1 After2
image Screen Shot 2023-06-13 at 2 36 33 AM Screen Shot 2023-06-13 at 2 36 20 AM

Note

  1. mb_convert_case was used because even though we don't seem to translate this page into any other languages, I guess we will in the future and this function will fit the case while ucwords won't. Also, I assume type in the database is specified as UTF-8.

  2. I'm not sure if it's worth doing (or best to do) more on our current layout. Perhaps adding some labels before each piece of information, like Time: 2:00 p.m., or adding a table for it, could be beneficial? What do you all think? And Is now a good time to bring the meta design into this discussion, or someone else should be tagged instead?

Testing Steps

Go to https://make.wordpress.org/community/events/ while sandboxed and check if the layout is the same as the screenshots above.

@renintw renintw self-assigned this Jun 12, 2023
@renintw renintw added the [Type] Enhancement New feature or request label Jun 12, 2023
@iandunn
Copy link
Member

iandunn commented Jun 12, 2023

Is now a good time to bring the meta design into this discussion

That seems like a good idea, they might have ideas about the labels, etc 👍🏻

@WordPress/meta-design

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, but may need a few tweaks before merge.

@jasmussen
Copy link

Seems like a fine micro improvement to what exists.

Provided you'd be up for potentially new tweaks at some point in the future, at some point we likely need to refresh these sections holistically to the new design. So it seems fine to go with an iterative improvement for now. What do you think?

@renintw
Copy link
Author

renintw commented Jun 13, 2023

So it seems fine to go with an iterative improvement for now. What do you think?

Thanks for jumping in. It makes sense to refresh the sections holistically. Regarding a micro improvement that doesn't require too much additional time, I agree that this is good to go 👍

@jasmussen
Copy link

Also just to clarify, by using the term "micro improvement" I didn't mean to belittle your work 😅 — on the contrary, I appreciate the constant iteration. Thank you.

@renintw
Copy link
Author

renintw commented Jun 13, 2023

Ah, I totally get it. Perhaps I should put it this way: "Given your feedback, I think there's no need to spend too much additional time atm, and a micro improvement would be good enough to go" Sorry for the confusion and much appreciated for the clarification 🙂

@jasmussen
Copy link

No confusion, all appreciation 🚀

@StevenDufresne
Copy link
Contributor

@renintw I think it's worth adding the context for this PR since it's separated from its driver (WordCamp pilot event MVP).

This update is being made in order to support the The Next Generation of WordCamps pilot event program. More traffic will be directed to this page and clearly communicating the event type has been identified as a needed improvement.

@renintw
Copy link
Author

renintw commented Jun 14, 2023

@renintw I think it's worth adding the context for this PR since it's separated from its driver (WordCamp pilot event MVP).

This update is being made in order to support the The Next Generation of WordCamps pilot event program. More traffic will be directed to this page and clearly communicating the event type has been identified as a needed improvement.

Thanks. I've added it to the PR description.

@pkevan
Copy link
Contributor

pkevan commented Jun 15, 2023

Not fully relevant to this PR, but how is the caching supposed to work here: https://github.com/WordPress/wordpress.org/pull/152/files#diff-040d01da7ce85154ff3542bb0faaaa35dfeca9941c16446fe1701fa30fe92c26R37-R50? Am I missing something?

@renintw
Copy link
Author

renintw commented Jun 20, 2023

Not fully relevant to this PR, but how is the caching supposed to work here: https://github.com/WordPress/wordpress.org/pull/152/files#diff-040d01da7ce85154ff3542bb0faaaa35dfeca9941c16446fe1701fa30fe92c26R37-R50? Am I missing something?

I think there might be a misuse of the term here. I'm guessing it might have meant to indicate that it had loaded some cached stuff, but they actually come from the DB. Not so sure about the real intent here in the first place, though.
Same stuff happens here.

If there are no further thoughts on this guess, I'll open a ticket later to address this minor issue.

@renintw
Copy link
Author

renintw commented Jun 20, 2023

As per the feedback from the community, I believe it's also worth adding event type to WP Dashboard event widget. Any concerns about doing so? @StevenDufresne @naokomc

@renintw renintw force-pushed the enhancement/event-list-ui-improvements branch from 8e8f067 to 9fe71d2 Compare June 20, 2023 11:12
bazza pushed a commit that referenced this pull request Jun 20, 2023
@renintw renintw closed this Jun 20, 2023
@renintw renintw force-pushed the enhancement/event-list-ui-improvements branch 2 times, most recently from 9fe71d2 to 18b4acd Compare June 20, 2023 11:36
@renintw renintw deleted the enhancement/event-list-ui-improvements branch June 20, 2023 17:05
@iandunn
Copy link
Member

iandunn commented Jun 21, 2023

I'm guessing it might have meant to indicate that it had loaded some cached stuff, but they actually come from the DB

Yeah, the database is acting as a local cache of the external APIs. It's not the canonical source, it's just a copy for performance.

IMO that's a correct use of the term, but I also agree that it might be worth a comment somewhere to clarify that it's not a memory cache 👍🏻

@renintw
Copy link
Author

renintw commented Jun 21, 2023

the database is acting as a local cache of the external APIs. It's not the canonical source

Ah, I see now, thanks for clarifying. I also agree that it's worth leaving a comment to explain this is not a mem cache 👍

@naokomc
Copy link

naokomc commented Jun 23, 2023

it's also worth adding event type to WP Dashboard event widget

If there's room for the label, I agree it'd be good additional information for the audience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Enhancement of Event List UI and Redirection Update for Events Domain
7 participants