Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trac: Add visually hidden or alternative text for attachment links #225

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Trac: Add visually hidden or alternative text for attachment links #225

wants to merge 2 commits into from

Conversation

sabernhardt
Copy link

  • "Download" and the file name are added as visually hidden text for raw attachment download links, at least within the comments area. (The "Download" title attribute is removed.)
  • The filename is inside its own container for use in the preview links. (The class could be applied to the first link instead, if preferable.)
  • The preview images could use the filename as alternative text in all cases, but I favored the user-added description—when available—in this patch.

https://meta.trac.wordpress.org/ticket/6319

@sabernhardt
Add visually hidden text in raw attachment link
c696645 
Removes `title` attribute and adds a `trac-attachment-name` class for possible use as the preview image `alt` text
@sabernhardt
Add alt attribute for attachment preview image
3ce1b1a 
Uses description if provided, or else it uses the filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sabernhardt