Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Network Themes page has blue color Disable text #52

Closed
paaljoachim opened this issue Apr 2, 2020 · 5 comments · Fixed by #54
Closed

Network Themes page has blue color Disable text #52

paaljoachim opened this issue Apr 2, 2020 · 5 comments · Fixed by #54

Comments

@paaljoachim
Copy link

As I just tested out a multisite and WP Auto Updates. I noticed that the Themes screen shows a blue color with the Disable text. It should be red.

Screen Shot 2020-04-03 at 01 39 02

@audrasjb
Copy link
Contributor

audrasjb commented Apr 3, 2020

Thanks for spotting this @paaljoachim.
#54 should fix the issue.

@pbiron
Copy link
Contributor

pbiron commented Apr 3, 2020

I'm not sure we should "fix" this...as I think the use of red for the disable link on the plugins screen is "wrong".

Disable auto-updates to me is analogous to Deactivate for plugins and the row action link for that is not red. Red is generally reserved for destructive actions (e.g., Delete) and I don't think disabling auto-updates is destructive.

@pbiron
Copy link
Contributor

pbiron commented Apr 3, 2020

That is, I agree that if we keep the disable link red on other screens then it should be read on the themes screen as well (for consistency). But I think the more consistent think would be to make it blue (or black, or whatever the design review suggests) on all screens.

@paaljoachim
Copy link
Author

Btw just looking at the regular Installed plugins screen as well as the themes screen to see how colors are used today.

Red is used when deleting a plugin or deleting a theme. As Paul says Red = destructive.
Blue is used for activating and deactivating a plugin.
Plugin titles are black.

Based on the existing method.
Disable and Enable should both be blue.

@paaljoachim
Copy link
Author

paaljoachim commented Apr 3, 2020

I played with it in Figma, and here is what it looks like when the first disable text is blue.
We need to bring this up again in the design channel.

Plugins screen

I made a specific issue with focus on color usage:
#56

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants