This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Self-deactivate the plugin after the functionality has been merged to core #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note that this is not ready for merging. The changes will need update and review after the core patch is ready (the new core function's places and names are known). |
Just marked this as |
|
@azaozz this is now ready to review |
|
Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will depend on where the functions are added in core.
If they are in
wp-admin/includes/*, they are loaded after plugins are loaded, so the plugin cannot check if they exist before loading. In this case the function names from the plugin cannot be reused for core (results in fatal error). Adding the two or three functions towp-admin/includes/update.phpseems to make sense. The current code in this PR is for this case.If they are in
wp-includes/*the existing method would work. The check whether plugins and themes auto-updating is (globally) enabled may be inwp-includes/update.php.In both of the above cases some updates to the code in
wp-autoupdates.phpwould be needed.