This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Update confirmation message wording #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbiron
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Looks great.
When we merge into core, I think we should have separate messages for the Enable/Disable links and the bulk actions, with the message for the links being Plugin/Theme will be auto-updated. and Plugin/Theme will no longer be auto-updated. That would match the current message text of Activate/Deactivate, which is different for row actions and bulk actions. Doing that in the feature plugin would take a bit of refactoring that I don't think is worthwhile at this point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per yesterday’s core-auto-updates meeting, this PR updates all confirmation messages.
For further context, see https://make.wordpress.org/core/2020/04/15/auto-updates-feature-meeting-summary-april-14th-2020/
Fixes #46