This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Accessibility: Communicate AJAX enabling/disabling changes to screen readers #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges to screen reader users
pbiron
reviewed
Apr 21, 2020
There was a problem hiding this comment.
I don't have a screen reader to test this with, but it basically looks good.
One question: shiny updates does wp.a11y.speak() when the update starts in addition to one when it has completed. Given how quickly the enable/disable happens we probably don't need the first one, but just wanted to ask.
|
Yes, you're right @pbiron. I tried both and I think it's not appropriate here, as the change is really quick, so I don't want to burden users with unnecessary notices 🙂 |
|
Merging this pull request right now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR usess
wp.a11y.speakto communicate action links AJAX changes to screen reader users.Fixes #84