feature(mvp): Stage 4 add item and collection schemas to rest api #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhooks
commented
Mar 24, 2023
johnhooks
commented
Mar 24, 2023
johnhooks
commented
Mar 24, 2023
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
31dd285
to
5ee567b
Compare
johnhooks
commented
Mar 26, 2023
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
2 times, most recently
from
bc0178e
to
bb0d296
Compare
|
@Sephsekla this is ready to review. Note: I'm not trying to commit us to anything, but just start work toward an actual rest-api. If anything in this needs to be adjusted as we work to implement notifications, I am 100% on board to either make the changes or support anyone doing the work. |
johnhooks
commented
Mar 27, 2023
Sephsekla
reviewed
Mar 31, 2023
Sephsekla
reviewed
Mar 31, 2023
johnhooks
commented
Mar 31, 2023
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
19b5817
to
075e454
Compare
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
075e454
to
6c05513
Compare
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
d02eb54
to
928afba
Compare
|
Work on this is being continued in #259 |
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
928afba
to
5108908
Compare
johnhooks
changed the title
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
5108908
to
27d5be9
Compare
johnhooks
force-pushed
the
feature/add-update-endpoint
branch
from
27d5be9
to
d07a449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implement item and collection schemas for notification the rest-api. Initiate PR early to get feedback, still lots to figure out.
Starts work on #176 to create an update rest endpoint for notifications.
Fixes #194
Why?
The rest-api of notifications should implement item and collection schemas.
How?
It adds schemas that the
WP_Rest_Controllercan use to validate api requests.Testing Instructions
Will need to do more research, but I'll be researching core tests and implement something similar.