Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add lint-staged #211

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Conversation

johnhooks
Copy link
Collaborator

@johnhooks johnhooks commented Apr 2, 2023

What?

Add and config lint-staged.

Why?

Currently the whole includes folder is linted in the pre-commit hook, which prevents commits when there were previous issues. Also the wp-feature-notification.php and the php tests are currently not being linted.

Adding lint-staged will allow linting only files that are staged for the commit

@johnhooks johnhooks requested a review from erikyo April 2, 2023 14:45
@johnhooks johnhooks added the [Type] development tools Setting up and cofniguring tools to help with the development process. label Apr 2, 2023
Copy link
Collaborator

@erikyo erikyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@johnhooks good job! it works perfectly thanks!

@erikyo erikyo merged commit 570651b into WordPress:develop Apr 2, 2023
@johnhooks johnhooks deleted the build/add-lint-staged branch April 2, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] development tools Setting up and cofniguring tools to help with the development process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants