Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/storybook controls #276

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented Apr 16, 2023

What?

In the first storybook implementation some controls were completely absent.

How?

as explained here i've provided some custom controls to the components, then linked the date picker

Testing Instructions

Start the storybook with npm run start:storybook then check the paths
wp-feature-notifications-notification-hub-single--single
wp-feature-notifications-dashboard-single--single

storybook

Adds the date picker to change the date
Updated storybook store constant
Copy link
Collaborator

@johnhooks johnhooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikyo erikyo merged commit e89796a into WordPress:develop Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants