Fix/70 locale a11y #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
fix/70-locale-a11y
branch
from
4487024
to
016ec92
Compare
adamwoodnz
force-pushed
the
fix/70-locale-a11y
branch
from
016ec92
to
a4d6d91
Compare
adamwoodnz
commented
Apr 27, 2023
adamwoodnz
force-pushed
the
fix/70-locale-a11y
branch
from
c277438
to
ab0ea19
Compare
when on desktop and tab into the autocomplete it displays fine, but when _clicking_ into it the `input` and `ul` are hidden. not sure if this will be needed after other changes though
iandunn
reviewed
May 3, 2023
- Push content down when menus are open - Fix flex layout of nav menu on mobile
mobile doesn't need it b/c of the border from `#masthead`
iandunn
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Branches off the initial commits in #71 with styles to get the autocomplete as close as possible to the designs and the current switcher on prod
Screenshots
Desktop
Mobile (emulated)
Mobile
The autoselected input text isn't a very nice experience on my Chrome for Android, as the contextual options are displayed, but I guess that is expected, and enables the input to be cleared with one tap of delete: