New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement front page #164
Implement front page #164
Conversation
source/wp-content/themes/wporg-developer-2023/src/style/style.scss
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This is 'Coding Standards' in the design |
This comment was marked as resolved.
This comment was marked as resolved.
Ah okay. Broke it by adding |
source/wp-content/themes/wporg-developer-2023/patterns/front-page-content.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-developer-2023/patterns/front-page-content.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-developer-2023/patterns/front-page-content.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few minor suggestions inline
One last thing, I received design feedback for Enterprise that the padding was too tight on sections like this on mobile (it should be 40px vertically) So I ended up overriding a preset just for that section: |
do_shortcode( 'wordpress_version_link' ), | ||
do_shortcode( 'wordpress_version') ); ?> | ||
</p> | ||
<p class="has-text-align-center has-extra-small-font-size"><?php echo wp_kses_post( 'See <a href="[wordpress_version_link]">what has changed</a> in the WordPress [wordpress_version] API.' ); ?></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N00b question; will this still show up as a translatable string? Or is that irrelevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a noob question. I'm working too fast trying to get this project moving :).
This is missing translation. Thanks for the catch.
That's a nice addition. I'll make the same change here. We can think more deeply about this should it keep coming up. |
Consistency is good, but which non-underlined designs are you referring to? I haven't been as involved here, so forgive me if I'm missing something obvious. But most links seem underlined in the Figma. Except those in the TOC, which should probably stay non-underlined:
@estelaris is this a question you can answer? |
source/wp-content/themes/wporg-developer-2023/parts/front-page-header.html
Outdated
Show resolved
Hide resolved
Out of curiosity, why did you decide to create a page template, pattern, template part, and have post content? In testing, I noticed the hover & focus color for the white outlined button on blue is very low-contrast. This does match the design library, so this is probably a question for @jasmussen - is this correct? The front page is missing an
This doesn't exist yet, as I understand it's a set of articles being moved from /support. According to this repo, it will eventually live at
Maybe https://developer.wordpress.org/apis/making-http-requests/? Though that's a guess.
Probably make.wordpress.org.
Currently the site links to the documentation contributor handbook, but in this context it seems like it should be something more generic. There's this handbook, which is in progress but doesn't seem very helpful at the moment (for getting involved). |
|
The navigation link list was different in the designs from the main one. That was corrected after the fact. I could remove the template and use CSS to change its color.
Translations.
I assumed all content had to be trackable in source control so I left only the link lists in the post content so it can be modified later. |
That doesn't look right, and won't fly. I don't think we necessarily need a hover style in this case (on this background) and the focus style can be white, a la what's on news: |
Okay, we'll fix this in the parent theme for white-outline buttons on blueberry 👍🏻 |
Why not just add this code in the page template (
Translations is a good reason for patterns, if there are plans to translate the site, but mixing the two (content & patterns) was what threw me off. |
Fair, I think I'll always go with a pattern until told otherwise. |
<!-- /wp:heading --></div> | ||
<!-- /wp:group --> | ||
|
||
<!-- wp:navigation {"textColor":"white","backgroundColor":"charcoal-2","className":"is-style-dropdown-on-mobile","style":{"spacing":{"blockGap":"24px"}},"fontSize":"small"} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this second navigation around for 2 reasons:
- Making the colors match is possible with CSS, but all the styles have
important
and we lose the ability to easily customize it in the editor. - The site-breadcrumb doesn't match the designs. It would require extra CSS to make that work.
Having 2 link lists is not super dry, but the best of 2 evils in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could try __unstableLocation
to reuse menu items in different navigation blocks by the location name, but it's unstable
and requires a little setup in the local environment to make it work. I keep meaning to do an experiment branch to wporg-parent when we're between projects but… 😩
4fbf96f
to
397d974
Compare
397d974
to
ba38808
Compare
ba38808
to
5c75623
Compare
I'm going to merge this for now and follow up with anything in the future. |
Closes: #158
This PR implements the front page.
Questions:
text-decoration: underline;
, but the new documentation site has them underlined. I assumed we want to make them the same. @javierarce @jasmussenScreenshot
Test
Post Content
below to the front page content.front-page-content.php
withhttps://user-images.githubusercontent.com/1657336/212520185-d9840a21-b149-49c6-b4f2-c043eaf969ea.svg
.Image For Testing
Link: https://user-images.githubusercontent.com/1657336/212520185-d9840a21-b149-49c6-b4f2-c043eaf969ea.svg