New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chapter list #305
Update chapter list #305
Conversation
4093118
to
9985277
Compare
Nice, this is a big win. I think it can in principle land as is. That said, per a recent revisit to this section, some opportunities for simplification were surfaced. In the case of the chapters list, it was mainly some small things:
You can dive into the Figma here. I noted some larger changes as well, which I'll show here for reference. I wouldn't call any of them urgent or blocking, but they simplify the overall appearance a bit, and could be applied across any section that uses chapters or tables of content, including Documentation. Notably the removal of dots and the background from the TOC. Both scroll with you down the page. "Back to top" can appear as you scroll a bit. Most of those changes are in the "enhancements" category and should not block anything, or even need be part of a V1. I can create issues separately if need be, but wanted your take on it first. Also a think for the future, and IMO also in the nice-to-have category is the expand/collapse behavior of the left sidebar. Here's the SVG for the new icon for that, which has also been added to the WordPress Design Library:
|
Thanks for the feedback @jasmussen !
👍 I'll make these changes in this PR I think
Yes please, a new issue in wporg-mu-plugins for the ToC changes. I might do the background and bullet changes quickly, then follow up with the rest.
👍 I've got a separate issue for this #306 I'll also tighten up the column spacing, but that doesn't need an issue. |
- Reduce width of chapter list and ToC - Retain column layout for chapter list and content on tablet
20ad806
to
4dfa5f0
Compare
Smaller icons and tighter spacing
Closes #265, #310, #313
Updates styling of chapter list:
Note: Does not include #306
Note also that the root handbook page is always shown in the current prod chapter list, so 'Best Practices' being shown on the WPCS page in the screenshots below is consistent with the other handbooks.
Screenshots
Coding standards
Block Editor
Advanced admin