New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirects for docs changes and update formatting #446
Add redirects for docs changes and update formatting #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in sandbox; existing redirects work going to new locations. New redirects won't work until the old pages 404, but new locations look good.
For redirects it's usually best to be explicit with them, rather than do some fancy regex or wildcard, so the method was good 👍 |
@pkevan do you know if this has been deployed yet? I have tested setting https://developer.wordpress.org/block-editor/getting-started/create-block/finishing/ to draft. This should redirect to https://developer.wordpress.org/block-editor/getting-started/tutorial, but I am still getting a 404. |
Not sure - will take a look. |
I think it might be the structure of the handbook page - presumably they all need to be draft in order for the redirects to work. i.e. |
Debugged and found the issue; the paths in $redirects shouldn't have a trailing slash. I'll push a fix. |
Ah, thanks @adamwoodnz. Sorry about that! |
Fixes issues with path comparison See #446
Deployed, appears to be fixed |
This PR adds redirects for a few recent changes to the Block Editor Handbook.
Note
Many of the redirects go to the same destination, so if there is a more efficient way of doing this, just let me know, and I'll update the PR.