-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand $args
array parameters that are described in other functions
#96
Conversation
I pushed up a commit to remove the I just changed it so it's "More Arguments". Feel free to change that to whatever works better :) An example on And on I'm also seeing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the
thing at all. Not sure what's up with that. Some kind of nl2br formatting, maybe on import? I re-ran an import and it didn't reproduce.
🤷🏻 I'm not seeing them on trunk, just this branch. Ah okay — I just rebased and they're gone now. I'm not sure why you weren't seeing them but when this merges it should be fine, at least.
Might be almost good enough to merge now for a designer to look at later - what do you think?
That works for me. I don't think it should look like a link (since it's not taking you anywhere), but we can iterate on that later.
Quick WIP version.
I'm sure this is the wrong way to solve the problem, but at least it looks more clickable.
3ba4dda
to
60db90e
Compare
Quick WIP version. See #95.
Before, on the get_terms() function reference:
![Screen Shot 2022-06-08 at 4 13 40 pm](https://user-images.githubusercontent.com/7200686/172544761-491de5bf-f0d3-44a6-b3db-40bb97caaf01.png)
After, collapsed (detail/summary tag - note the teeny tiny triangle):
![Screen Shot 2022-06-08 at 4 15 11 pm](https://user-images.githubusercontent.com/7200686/172545485-4bbc0c96-36a5-41ab-b4c2-673a8bc7d759.png)
After, expanded:
![Screen Shot 2022-06-08 at 4 15 25 pm](https://user-images.githubusercontent.com/7200686/172545535-ef2d99a6-03f9-4aa7-b4b2-506d0c3b8874.png)
Before, on get_posts(). Note that this one has a few arguments explicitly documented:
![Screen Shot 2022-06-08 at 4 21 35 pm](https://user-images.githubusercontent.com/7200686/172546064-a6b32bc1-8c5d-4998-8d88-c5f03f6e9e7c.png)
After, collapsed:
![Screen Shot 2022-06-08 at 4 21 51 pm](https://user-images.githubusercontent.com/7200686/172546227-e502eba8-427b-49ad-ad22-3e2ffcae0b4f.png)
After, expanded (note that it still has the explicit docs first, I haven't hidden that):
![Screen Shot 2022-06-08 at 4 22 28 pm](https://user-images.githubusercontent.com/7200686/172546334-1b02b7a3-4d27-4626-98ed-d7cbc1d3426a.png)
There are definitely some improvements needed especially on the front-end. But this seems to work pretty well at recursing through and finding the correct array. For example it works with multiple levels of indirection, like
wp_count_terms($args) -> get_terms($args) -> WP_Term_Query::__construct($query)
.