Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database upgrade #197

Merged
merged 12 commits into from Apr 10, 2024
Merged

Database upgrade #197

merged 12 commits into from Apr 10, 2024

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Apr 8, 2024 •
edited

Fixes #195

@psrpinto psrpinto changed the base branch from trunk to store-attendees April 8, 2024 15:46
@psrpinto psrpinto self-assigned this Apr 8, 2024
@psrpinto psrpinto linked an issue Apr 8, 2024 that may be closed by this pull request
Implement database upgrade system #195
Closed
2 tasks
@psrpinto psrpinto force-pushed the database-upgrade branch 4 times, most recently from 58c0900 to 3e8c2a6 Compare April 9, 2024 14:46
Base automatically changed from store-attendees to trunk April 9, 2024 15:10
@psrpinto psrpinto marked this pull request as ready for review April 9, 2024 16:36
akirk
akirk reviewed Apr 10, 2024
View reviewed changes
includes/upgrade.php Outdated Show resolved Hide resolved
@akirk
Copy link
Collaborator

akirk commented Apr 10, 2024

Should we keep it as is, or should we do it on every request to wp-admin? Or another alternative? Please let me know.

I'd prefer it to go the GlotPress way and do it upon every is_admin() request.

I've tested the PR and it works well upon plugin activation.

@psrpinto psrpinto requested a review from akirk April 10, 2024 14:40
@psrpinto @akirk
Don't set version 1
c601e82 
Co-authored-by: Alex Kirk <akirk@users.noreply.github.com>
@psrpinto
Copy link
Member Author

This should be good to go now.

akirk
akirk approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@psrpinto psrpinto merged commit 6c52182 into trunk Apr 10, 2024
3 checks passed
@psrpinto psrpinto deleted the database-upgrade branch April 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk akirk approved these changes

@amieiro amieiro Awaiting requested review from amieiro

@trymebytes trymebytes Awaiting requested review from trymebytes

Assignees

@psrpinto psrpinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement database upgrade system
2 participants
@psrpinto @akirk