Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attendees #240

Merged
merged 13 commits into from
May 9, 2024
Merged

Remove attendees #240

merged 13 commits into from
May 9, 2024

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented May 2, 2024 •
edited
Loading

Fixes #63 It adds a link to each row of attendee that allows event hosts or admins remove attendees from an event.

Screenshot 2024-05-02 at 13 38 51

@trymebytes trymebytes changed the base branch from trunk to manage-attendees May 2, 2024 12:36
@trymebytes trymebytes marked this pull request as draft May 2, 2024 12:37
@trymebytes trymebytes linked an issue May 2, 2024 that may be closed by this pull request
Allow to remove somebody from an Event #63
Closed
Base automatically changed from manage-attendees to trunk May 3, 2024 12:48
@trymebytes trymebytes marked this pull request as ready for review May 6, 2024 15:43
@akirk
Copy link
Collaborator

akirk commented May 7, 2024

I took the liberty to do some style finetuning:
Screenshot 2024-05-07 at 08 01 18

akirk
akirk previously requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to remove myself, I get a whitepage with just the text "You do not have permission to remove this attendee." This is not very nice UI. Why not hide the button?

@akirk
Copy link
Collaborator

akirk commented May 7, 2024

Tosin and I agreed to not show the button for hosts. If you'd want to remove a host, you need to remove them from being a host first.

@akirk akirk mentioned this pull request May 7, 2024
Closed
@trymebytes trymebytes requested a review from akirk May 7, 2024 12:29
psrpinto
psrpinto reviewed May 8, 2024
View reviewed changes
wporg-gp-translation-events.php Outdated Show resolved Hide resolved
includes/routes/attendee/remove-attendee.php Outdated Show resolved Hide resolved
autoload.php Outdated Show resolved Hide resolved
@trymebytes trymebytes requested a review from psrpinto May 9, 2024 13:02
psrpinto
psrpinto approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trymebytes trymebytes merged commit be69147 into trunk May 9, 2024
3 checks passed
@trymebytes trymebytes deleted the remove-attendees branch May 9, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrpinto psrpinto psrpinto approved these changes

@amieiro amieiro Awaiting requested review from amieiro

@akirk akirk Awaiting requested review from akirk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to remove somebody from an Event
3 participants
@trymebytes @akirk @psrpinto