Add & sync download subpages #131
Conversation
ryelle
force-pushed
the
add/download-subpages
branch
from
732a9bc
to
db20206
Compare
ryelle
force-pushed
the
add/download-subpages
branch
from
bc2b976
to
5dcea31
Compare
ryelle
force-pushed
the
add/download-subpages
branch
3 times, most recently
from
d0fef41
to
6c36329
Compare
* Use the new theme for all `wp*` endpoints This enables the new theme on `/wporg/v1/` endpoints as well as core `/wp/v2/`. * Add Download Counter block & endpoint * Style the download counter block * Add a shortcode for the latest branch constant. * Update Counter page pattern * Catch errors in JS * Rename shortcode Technically the "latest" branch would be the one in development, so rename this to better reflect its value. * Use charcoal-2 background color * Use `textContent` for safety, since the count value is plain text * Update font to new monospace font * Use the extra-light font weight
* Initial Release Tables block * Add the toggle view for older releases * Visually hide table headers, add responsive styles * Always make sure the headers are hidden * Align all the links, even when they wrap to new lines * Add a function check * Remove unnecessary settings * Replace bar with middot in hash links
…h Stroke" group block.
ryelle
force-pushed
the
add/download-subpages
branch
from
6c36329
to
6d8a6d5
Compare
|
All the code parts have been reviewed in other PRs, so the only this needs is a design review. Feel free to tag in any other designers who should be involved. Hopefully if there's anything minor (or anything in the content), we can tweak that in the editor after merge, and re-sync the content. |
|
At a glance, looks good to me! The download counter on mobile may look a bit tall, in how it appears to push some of the footer links to be in an awkward place mid-fold, but perhaps that's related to the adminbar? Probably fine. |
|
A minor thing that could be tweaked after the merge: if possible, I would just reduce the font size of the "Number of WordPress 6.0 downloads" and increase the margin between that line and the counter to get closer to the original design. The rest looks good to me ✨ |
|
@jasmussen @javierarce I think you can tweak those things once I've deployed this, since the issues you've raised can be fixed in the editor. Once you've got it the way you want, I can re-sync the patterns. |
Fixes #129 — This branch has all the download subpages in one place. This contains #132 & #134, and uses WordPress/wporg-parent-2021#48.
This enables the syncing for all 4 download subpages: Releases, Nightly, Counter, Source. Once we merge this, the new design can be enabled on these pages.
There was discussion about the subnavigation bar on #129 — I've added a basic iteration but the actual alignment can be iterated on in the editor after merge, if necessary.
Screenshots
Note, the above screenshots were taken before the mobile nav button was updated to use the down-chevron - it looks like this now:
How to test the changes in this Pull Request:
Visit the 4 download subpages on your local site.